-
-
Notifications
You must be signed in to change notification settings - Fork 17
fixed show dark mode #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed show dark mode #142
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=========================================
Coverage 77.47% 77.47%
Complexity 184 184
=========================================
Files 14 14
Lines 586 586
=========================================
Hits 454 454
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to remove section "@media (prefers-color-scheme: dark) { ..." from CSS
this will cause flickering. |
Btw, you may access cookies in backend |
flickering occurs |
anyway, "flickering" occurs without your changes, isn't it? |
|
@vjik |
vjik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line to changelog
|
Thank you @pamparam83 ! |
Added a check for dark mode.
If the system’s theme cannot be detected, we default to the light theme.
Due to a known issue in Linux OS (see https://issues.chromium.org/issues/40642550),
Linux users will also get the light theme by default.